Re: [PATCH v12 0/2] MR8367: shell32: Add shield icon.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/shell32/iconcache.c:
>  sii->iIcon = -IDI_SHELL_FILE;
>  lstrcatW(sii->szPath, L"\\shell32.dll");
>
> - if (flags)
> -
>    FIXME("flags 0x%x not implemented\n", flags);
> -
>
> if (flags & ~SHGSI_ICON)
> -
>    FIXME("unhandled flags 0x%x\n", flags);
>
> sii->hIcon = NULL;
>    if (flags & SHGSI_ICON)
> -
>    sii->hIcon = LoadIconW(GetModuleHandleW(sii->szPath), MAKEINTRESOURCEW(sii->iIcon));
> -
>    sii->hIcon = LoadIconW(GetModuleHandleW(sii->szPath), MAKEINTRESOURCEW(stock_icon_id_to_resource_id(id)));
> sii->iSysImageIndex = -1;

Could you add some tests for SHGetStockIconInfo() regarding this change?