Re: [PATCH 0/3] MR6408: odbc32: Handle odbcv2 for GetData

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/odbc32/proxyodbc.c:
>          return SQL_ERROR;
>      }
>
> -
>    return stmt->hdr.win32_funcs->SQLColAttributesW( stmt->hdr.win32_handle, col, field_id, char_attr, buflen,
> -
>    ret = stmt->hdr.win32_funcs->SQLColAttributesW( stmt->hdr.win32_handle, col, field_id, char_attr, buflen,
>                                                     retlen, num_attr );
> -
>    /* Convert back for ODBC3 drivers */
> -
>    if (num_attr && field_id == SQL_COLUMN_TYPE &&
> -
>            ((struct environment*)(stmt->hdr.parent))->attr_version == SQL_OV_ODBC2 &&
> -
>            ((struct environment*)(stmt->hdr.parent))->driver_ver == SQL_OV_ODBC2)

The comment doesn't match the condition. This should probably only be done when the call succeeds.