Re: [PATCH v2 0/5] MR8326: ntdll: Implement RtlActivateActivationContextUnsafeFast().

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/kernel32/tests/actctx.c:
> -
>    skip("Could not create manifest file\n");
> -
>    return;
> - }
> - handle = test_create("test1.manifest");
> - ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %lu\n", GetLastError());
> - DeleteFileA("test1.manifest");
> - if (handle != INVALID_HANDLE_VALUE)
> - {
> -
>    b = ActivateActCtx(handle, &cookie);
> -
>    ok(b, "ActivateActCtx failed: %lu\n", GetLastError());
> -
> -
>    frame = NtCurrentTeb()->ActivationContextStackPointer->ActiveFrame;
> -
>    ok(!frame->Previous, "Got unexpected Previous.\n");
> -
>    ok(frame->ActivationContext == handle, "Got unexpected ActivationContext.\n");
> -
>    todo_wine
> -
>    ok(frame->Flags == 0x28, "Got unexpected Flags %#lx.\n", frame->Flags);

We don't know what 0x20 means in this mask. Important difference here is 0x8 bit. I would test only for what we know the meaning of.