3 Aug
2023
3 Aug
'23
11:01 a.m.
On Thu Aug 3 10:48:14 2023 +0000, Vitaly Lipatov wrote:
I have checked there are many comments like this in other wine's structs. Need we remove it too?
git grep "_WIN32_WINNT >" dlls/shlwapi/assoc.c:#if _WIN32_WINNT > 0x602 dlls/shlwapi/assoc.c:#if _WIN32_WINNT >= 0x600 include/commctrl.h: /* (_WIN32_WINNT >= 0x0600) */ include/commctrl.h: /* (_WIN32_WINNT >= 0x0600) */ include/commctrl.h:/* Button control styles for _WIN32_WINNT >= 0x600 */ include/commctrl.h: /* _WIN32_WINNT >= 0x0600 */ include/commctrl.h: /* _WIN32_WINNT >= 0x0600 */ include/commctrl.h: /* (_WIN32_WINNT >= 0x0600) */ include/commctrl.h: /* (_WIN32_WINNT >= 0x0600) */ include/commctrl.h: /* (_WIN32_WINNT >= 0x0600) */ include/commctrl.h: /* (_WIN32_WINNT >= 0x0600) */ include/commctrl.h: /* (_WIN32_WINNT >= 0x0600) */ include/commctrl.h: /* (_WIN32_WINNT >= 0x0600) */ include/commctrl.h: /* (_WIN32_WINNT >= 0x0600) */ include/wia.h:#if (_WIN32_WINNT >= 0x0600) include/wia.h:#elif (_WIN32_WINNT >= 0x0501) include/winioctl.h:/* Start: _WIN32_WINNT >= 0x0400 */ include/winioctl.h:/* End: _WIN32_WINNT >= 0x0400 */ include/winuser.h:#if (_WIN32_WINNT >= 0x0601) include/winuser.h:#elif (_WIN32_WINNT >= 0x0501)
If you count the comments (not the preprocessor conditions) it's only 14 occurrences in two headers. I don't think that's many. More importantly I don't think we need to document this in Wine.