[PATCH v20 2/3] mfplat/tests: Validate MFCancelWorkItem releases the callback.

[Yuxuan Shui]

From: Yuxuan Shui

---
 dlls/mfplat/tests/mfplat.c | 64 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/dlls/mfplat/tests/mfplat.c b/dlls/mfplat/tests/mfplat.c
index 904e8808305..abad318f886 100644
--- a/dlls/mfplat/tests/mfplat.c
+++ b/dlls/mfplat/tests/mfplat.c
@@ -585,6 +585,51 @@ static const IMFAsyncCallbackVtbl test_async_callback_result_vtbl =
     test_async_callback_result_Invoke,
 };

+/* Test context for MFAddPeriodCallback. */
+struct test_context
+{
+    IUnknown IUnknown_iface;
+    LONG refcount;
+};
+
+static struct test_context *test_context_from_IUnknown(IUnknown *iface)
+{
+    return CONTAINING_RECORD(iface, struct test_context, IUnknown_iface);
+}
+
+static HRESULT WINAPI test_context_QueryInterface(IUnknown *iface, REFIID riid, void **obj)
+{
+    if (IsEqualIID(riid, &IID_IUnknown))
+    {
+        *obj = iface;
+        IUnknown_AddRef(iface);
+        return S_OK;
+    }
+
+    *obj = NULL;
+    return E_NOINTERFACE;
+}
+
+static ULONG WINAPI test_context_AddRef(IUnknown *iface)
+{
+    struct test_context *context = test_context_from_IUnknown(iface);
+    return InterlockedIncrement(&context->refcount);
+}
+
+static ULONG WINAPI test_context_Release(IUnknown *iface)
+{
+    struct test_context *context = test_context_from_IUnknown(iface);
+    ULONG refcount = InterlockedDecrement(&context->refcount);
+    return refcount;
+}
+
+static const IUnknownVtbl test_context_vtbl =
+{
+    test_context_QueryInterface,
+    test_context_AddRef,
+    test_context_Release,
+};
+
 static DWORD wait_async_callback_result(IMFAsyncCallback *iface, DWORD timeout, IMFAsyncResult **result)
 {
     struct test_callback *callback = impl_from_IMFAsyncCallback(iface);
@@ -3599,6 +3644,7 @@ static void test_scheduled_items(void)
     IMFAsyncResult *result;
     MFWORKITEM_KEY key, key2;
     HRESULT hr;
+    ULONG refcount;

callback = create_test_callback(NULL);

@@ -3611,6 +3657,9 @@ static void test_scheduled_items(void)
     hr = MFCancelWorkItem(key);
     ok(hr == S_OK, "Failed to cancel item, hr %#lx.\n", hr);

+    refcount = IMFAsyncCallback_Release(&callback->IMFAsyncCallback_iface);
+    todo_wine ok(refcount == 0, "Unexpected refcount %lu.\n", refcount);
+
     hr = MFCancelWorkItem(key);
     ok(hr == MF_E_NOT_FOUND || broken(hr == S_OK) /* < win10 */, "Unexpected hr %#lx.\n", hr);

@@ -3620,6 +3669,8 @@ static void test_scheduled_items(void)
         return;
     }

+    callback = create_test_callback(NULL);
+
     hr = MFCreateAsyncResult(NULL, &callback->IMFAsyncCallback_iface, NULL, &result);
     ok(hr == S_OK, "Failed to create result, hr %#lx.\n", hr);

@@ -3716,6 +3767,10 @@ static void test_periodic_callback(void)
 {
     DWORD period, key;
     HRESULT hr;
+    struct test_context context = {
+        .IUnknown_iface = { &test_context_vtbl },
+        .refcount = 1,
+    };

hr = MFStartup(MF_VERSION, MFSTARTUP_FULL);
     ok(hr == S_OK, "Failed to start up, hr %#lx.\n", hr);
@@ -3746,6 +3801,15 @@ static void test_periodic_callback(void)

ok(periodic_counter > 0, "Unexpected counter value %lu.\n", periodic_counter);

+    hr= pMFAddPeriodicCallback(periodic_callback, &context.IUnknown_iface, &key);
+    ok(hr == S_OK, "Failed to add periodic callback, hr %#lx.\n", hr);
+    ok(context.refcount == 2, "Unexpected refcount %ld.\n", context.refcount);
+
+    hr = pMFRemovePeriodicCallback(key);
+    ok(hr == S_OK, "Failed to remove callback, hr %#lx.\n", hr);
+    Sleep(500);
+    todo_wine ok(context.refcount == 1, "Unexpected refcount %ld.\n", context.refcount);
+
     hr = MFShutdown();
     ok(hr == S_OK, "Failed to shut down, hr %#lx.\n", hr);
 }