Re: [PATCH v15 0/6] MR6402: bluetoothapis: Implement basic SDP methods.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/bluetoothapis/sdp.c:
> -
>    data->type = type;
> -
>    data->specificType = st;
> -
>    break;
> - case SDP_TYPE_BOOLEAN:
> -
>    if (size_desc != SDP_SIZEDESC_1_BYTE) return ERROR_INVALID_PARAMETER;
> -
>    if (stream_size < sizeof(BYTE)) return ERROR_INVALID_PARAMETER;
> -
> -
>    data->type = type;
> -
>    data->specificType = SDP_ST_NONE;
> -
>    data->data.booleanVal = *stream;
> -
>    *read += sizeof( BYTE );
> -
>    break;
> - case SDP_TYPE_STRING:
> - case SDP_TYPE_URL:
> - case SDP_TYPE_SEQUENCE:
> - case SDP_TYPE_ALTERNATIVE:

As a suggestion for how this large chunk could be split (maybe not strictly necessary here but feel free to do it if you are happy to): you could test, then implement, each category of element type separately.