Rémi Bernon (@rbernon) commented about dlls/mf/tests/transform.c:
winetest_push_context("%lu", i);
ok(hr == S_OK, "ProcessOutput returned %#lx\n", hr);
hr = IMFCollection_AddElement(output_samples, (IUnknown *)output_sample);
ok(hr == S_OK, "AddElement returned %#lx\n", hr);
ref = IMFSample_Release(output_sample);
ok(ref == 1, "Release returned %ld\n", ref);
output_sample = create_sample(NULL, expect_output_info.cbSize);
winetest_pop_context();
- }
- ok(hr == MF_E_TRANSFORM_NEED_MORE_INPUT, "ProcessOutput returned %#lx\n", hr);
- ret = IMFSample_Release(output_sample);
- ok(ret == 0, "Release returned %lu\n", ret);
- ok(i == 1, "got %lu output samples\n", i);
- ret = check_mf_sample_collection(output_samples, &output_sample_desc_nv12, L"nv12frame.bmp");
- ok(ret == 0, "got %lu%% diff\n", ret);
I'm thinking that maybe this could be factored out in some way, as you do almost the same 50 lines 10 times or so.