Re: [PATCH v2 0/5] MR7636: d3dx9: Implement saving to DDS files in D3DXSaveTextureToFileInMemory().

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/texture.c:
> -
>    BOOL todo_expected;
> - } tests[] =
> - {
> -
>    /* Paletted format tests. */
> -
>    { D3DRTYPE_TEXTURE, D3DFMT_P8, D3DPOOL_SCRATCH, 4, 4, 0, 3, test_palette, D3D_OK,
> -
>      { 32, DDS_PF_INDEXED, 0, 8, 0, 0, 0, 0 },
> -
>      (DDSD_CAPS | DDSD_HEIGHT | DDSD_WIDTH | DDSD_PIXELFORMAT | DDSD_MIPMAPCOUNT), 4, 4, 0, 0, 3,
> -
>      (DDSCAPS_TEXTURE | DDSCAPS_PALETTE | DDSCAPS_MIPMAP | DDSCAPS_COMPLEX), 0, PALETTED_DDS_FILE_HEADER_SIZE + 21,
> -
>      .todo_hr = TRUE
> -
>    },
> -
>    { D3DRTYPE_CUBETEXTURE, D3DFMT_P8, D3DPOOL_SCRATCH, 4, 0, 0, 3, test_palette, D3D_OK,
> -
>      { 32, DDS_PF_INDEXED, 0, 8, 0, 0, 0, 0 },
> -
>      (DDSD_CAPS | DDSD_HEIGHT | DDSD_WIDTH | DDSD_PIXELFORMAT | DDSD_MIPMAPCOUNT), 4, 4, 0, 0, 3,
> -
>      (DDSCAPS_TEXTURE | DDSCAPS_PALETTE | DDSCAPS_MIPMAP | DDSCAPS_COMPLEX),
> -
>      (DDSCAPS2_CUBEMAP | DDSCAPS2_CUBEMAP_ALLFACES),
> -
>      PALETTED_DDS_FILE_HEADER_SIZE + (126), .todo_hr = TRUE

What happened here? I guess you originally had `21 * 6`, then replaced it with the result and the (unnecessary either way) parentheses remained?

Same issue below.