Re: [PATCH v3 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW

[Alex Henrie (＠alexhenrie)]

Alex Henrie (@alexhenrie) commented about dlls/setupapi/tests/query.c:
> -
>    ok(result == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND), "Got %lx\n", result);
> - else
> -
>    todo_wine
> -
>    ok(result == E_INVALIDARG, "Got %lx\n", result); /* Win64 needs flags 0x9, or it gives invalid parameter */
> -
> - /* Invalid parameter tests */
> -
> - result = pDriverStoreFindDriverPackageW(L"c:\nonexistant.inf", 0, 0, 9, 0, 0, &len);
> - ok(result == E_INVALIDARG, "Got %lx\n", result);
> -
> - result = pDriverStoreFindDriverPackageW(0, 0, 0, 9, 0, buffer, &len);
> - ok(result == E_INVALIDARG, "Got %lx\n", result);
> -
> - result = pDriverStoreFindDriverPackageW(L"", 0, 0, 9, 0, buffer, &len);
> - todo_wine
> - ok(result == 0x8007007b || result == E_INVALIDARG, "Got %lx\n", result); /* Win7 and Win10 have different results */

0x8007007b is HRESULT_FROM_WIN32(ERROR_INVALID_NAME). Let's use the macro instead of a magic number, assume that ERROR_INVALID_NAME is broken behavior, and make Wine return E_INVALIDARG in this situation.