Re: [PATCH 0/4] MR2258: winegstreamer: Support WMV DMO decoder.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/gst_private.h:
> HRESULT wg_sample_create_mf(IMFSample *sample, struct wg_sample **out);
>  HRESULT wg_sample_create_quartz(IMediaSample *sample, struct wg_sample **out);
> +HRESULT wg_sample_create_dmo(IMediaBuffer *media_buffer, struct wg_sample **out);
>  void wg_sample_release(struct wg_sample *wg_sample);
>
> HRESULT wg_transform_push_mf(struct wg_transform *transform, IMFSample *sample,
>          struct wg_sample_queue *queue);
>  HRESULT wg_transform_push_quartz(struct wg_transform *transform, struct wg_sample *sample,
>          struct wg_sample_queue *queue);
> +HRESULT wg_transform_push_dmo(struct wg_transform *transform, IMediaBuffer *media_buffer,
> -
>    DWORD flags, REFERENCE_TIME time_stamp, REFERENCE_TIME time_length, struct wg_sample_queue *queue);
>
> HRESULT wg_transform_read_mf(struct wg_transform *transform, IMFSample *sample,
>          DWORD sample_size, struct wg_format *format, DWORD *flags);
>  HRESULT wg_transform_read_quartz(struct wg_transform *transform, struct wg_sample *sample);
> +HRESULT wg_transform_read_dmo(struct wg_transform *transform, DMO_OUTPUT_DATA_BUFFER *buffer, struct wg_format *format);

You're adding these but they aren't used anywhere, so it's dead code. You should probably introduce these whenever you implement ProcessOutput / ProcessInput (maybe separately?).