Re: [PATCH v4 0/2] MR184: vkd3d-shader/hlsl: Add support for SampleGrad() method

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.y:
> - switch (dim)
> - {
> -
>    case HLSL_SAMPLER_DIM_1D:
> -
>    case HLSL_SAMPLER_DIM_1DARRAY:
> -
>        return 1;
> -
>    case HLSL_SAMPLER_DIM_2D:
> -
>    case HLSL_SAMPLER_DIM_2DARRAY:
> -
>        return 2;
> -
>    case HLSL_SAMPLER_DIM_3D:
> -
>    case HLSL_SAMPLER_DIM_CUBE:
> -
>    case HLSL_SAMPLER_DIM_CUBEARRAY:
> -
>        return 3;
> -
>    case HLSL_SAMPLER_DIM_2DMS:
> -
>    case HLSL_SAMPLER_DIM_2DMSARRAY:
> -
>        /* Offset parameters not supported for these types. */
> -
>        return 0;

The comment doesn't belong here. Just remove these two cases, they're not reachable anyway.