On Fri Oct 25 11:43:28 2024 +0000, Connor McAdams wrote:
I've uploaded a [branch](https://gitlab.winehq.org/cmcadams/wine/-/commits/WIP/d3dx9-new-fmt-id-v1) doing this without WIC conversion, let me know what you think :) This avoids doing any conversion at all, it just reports a different format in the `D3DXIMAGE_INFO` structure than the format stored in the `d3dx_image` structure. If you think the approach in that branch is better, I can close this MR and open another one with the patches from that branch instead.
If I understand the patches in the branch correctly, you're basically deferring conversion to `D3DXLoadSurface*()` time, which all in all seems nicer to me.
I tried to look for anything breaking with the new approach (e.g. I was wondering about `D3DXCreateTextureFromFileInMemoryEx()` - it should be fine since it already takes the format from `d3dximage_info_from_d3dx_image()`) but I couldn't immediately find anything and, in general, tests should help with that concern.
I have some specific questions on a couple details, but those are probably better reserved to the actual MR :smile: