On Wed Mar 26 18:18:50 2025 +0000, Alfred Agrell wrote:
It's the merge commit, we don't want those. Rebase, delete the now-empty commit, and force push. We're not huge fans of commits that fix previous commits either; squash those three to one and force push, so it looks like you got it right the first time. You've got the names backwards in that list - minimum power savings equals maximum power use and maximum performance. This MR could also use some more tests, FIXME("stub") on the ERROR_CALL_NOT_IMPLEMENTED returns, and FIXME("semi-stub") for that piece about storing power profiles in registry. (I'm not the local maintainer, so I don't know how much of the above, and how much else, needs to be done for the MR to be approved. Feel free to ignore me if you feel I'm crazy.)
Thank you! That username issue was driving me crazy.
I'll probably just copy the files I modified, blow away the fork, recreate and add back.
And good catch on the GUID names :smile: