Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.

[eric pouech (＠epo)]

eric pouech (@epo) commented about programs/cmd/wcmdmain.c:
> -
>
> +static void set_cursor_visible(const HANDLE hOutput, const BOOL visible)
> +{
> - CONSOLE_CURSOR_INFO cursorInfo;
> -
> - if (GetConsoleCursorInfo(hOutput, &cursorInfo)) {
> -
>    cursorInfo.bVisible = visible;
> -
>    SetConsoleCursorInfo(hOutput, &cursorInfo);
> - }
>
> +}
> -
>
> +static void build_search_string(WCHAR *inputBuffer, int len, SEARCH_CONTEXT *sc)
> +{
> - int cc = 0, nn = 0;
> - WCHAR *param = NULL, *last_param, *stripped_copy = NULL;
> - WCHAR last_stripped_copy[MAX_PATH] = L"\0";

you likely want MAXSTRING here (native definitively works on strings longer than 260 chars)