Re: [PATCH v4 0/2] MR5810: Set the default period to a minimum of 10 ms in mmdevapi instead of the audio driver.

[Davide Beatrici (＠davidebeatrici)]

Davide Beatrici (@davidebeatrici) commented about dlls/mmdevapi/client.c:
> +static HRESULT get_periods(struct audio_client *client,
>                             REFERENCE_TIME *def_period, REFERENCE_TIME *min_period)
>  {
>      static const REFERENCE_TIME min_def_period = 100000; /* 10 ms */
>      struct get_device_period_params params;
> - params.device     = This->device_name;
> - params.flow       = This->dataflow;
> -
>
> params.device     = client->device_name;
> -
>
> params.flow       = client->dataflow;
> params.def_period = def_period;
> params.min_period = min_period;
>
> wine_unix_call(get_device_period, &params);
> - TRACE("Device periods: %lu default and %lu minimum\n", (ULONG)*def_period, (ULONG)*min_period);

For reference, the reason why I moved this debug message here is to know the default period reported by the backend in case of problems (e.g. glitches, xruns).

However, I believe it's better to write one in the driver's code instead.