Re: [PATCH v2 0/4] MR3517: Fixes for GDI/GDI+ newline measurements.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/win32u/font.c:
> -
>        return TRUE;
> - }
> - ctype1 = get_char_type( CT_CTYPE1, glyph );
> - ctype2 = get_char_type( CT_CTYPE2, glyph );
> - ctype3 = get_char_type( CT_CTYPE3, glyph );
> - if (ctype1 == 0x268 && ctype2 == 9 && ctype3 == 0x8)
> -
>    return TRUE;
> - if (ctype1 == 0x228 && ctype2 == 8 && ctype3 == 0x8)
> -
>    return TRUE;
> - if (ctype1 == 0x220 && ctype2 == 8 && ctype3 == 0x0)
> -
>    return TRUE;
> - if (ctype1 == 0x220 && ctype2 == 9 && ctype3 == 0x0)
> -
>    return TRUE;
> - /* Incomplete, but this is the best I got. */
> - return FALSE;
>
> +}

There is a helper called get_char_sa() in dwrite, is it too far off? Another, possibly more important, question I have is how does this work for GGO_GLYPH_INDEX? Isn't 'glyph' already an index in that case? ('index' argument is unused by the way)