Re: [PATCH v28 4/4] kernel32: Implement GetFirmwareEnvironmentVariableExA, GetFirmwareEnvironmentVariableExW, GetFirmwareEnv

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=148324

Your paranoid android.

=== w1064_adm (64 bit report) ===

kernel32:
firmware.c:115: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:132: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:137: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:142: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:147: Test failed: Expected ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:172: Test failed: Expected status > 0, got error 1314
firmware.c:190: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:195: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:200: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:205: Test failed: Expected ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:230: Test failed: Expected status > 0, got error 1314
firmware.c:249: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:254: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:259: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:264: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:269: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:274: Test failed: Expected ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:299: Test failed: Expected status > 0, got error 1314
firmware.c:317: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:322: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:327: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:332: Test failed: Expected ERROR_INVALID_PARAMETER, got error 1314.
firmware.c:337: Test failed: Expected status > 0 or GetLastError() == ERROR_ENVVAR_NOT_FOUND, got error 1314.
firmware.c:342: Test failed: Expected ERROR_ENVVAR_NOT_FOUND, got error 1314.

=== w10pro64_en_AE_u8 (32 bit report) ===

kernel32:
heap.c:3314: Test failed: HeapValidate failed
heap.c:3323: Test failed: HeapValidate failed

=== w10pro64 (32 bit report) ===

kernel32:
loader.c:3616: Test failed: expected thread exit code 196, got 259
loader.c:3616: Test failed: expected thread exit code 196, got 259
loader.c:3109: Test failed: expected thread exit code 196, got 195
loader.c:3109: Test failed: expected thread exit code 196, got 195

=== w7u_2qxl (32 bit report) ===

ntdll:
info.c:348: Test failed: Expected ret_size == sizeof(SYSTEM_BOOT_ENVIRONMENT_INFORMATION).

=== w7u_adm (32 bit report) ===

ntdll:
info.c:348: Test failed: Expected ret_size == sizeof(SYSTEM_BOOT_ENVIRONMENT_INFORMATION).

=== w7u_el (32 bit report) ===

ntdll:
info.c:348: Test failed: Expected ret_size == sizeof(SYSTEM_BOOT_ENVIRONMENT_INFORMATION).

=== w1064_tsign (32 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w10pro64 (32 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w10pro64_en_AE_u8 (32 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w11pro64 (32 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w7pro64 (64 bit report) ===

ntdll:
info.c:348: Test failed: Expected ret_size == sizeof(SYSTEM_BOOT_ENVIRONMENT_INFORMATION).

=== w1064_2qxl (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w1064_adm (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w1064_tsign (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w10pro64 (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w10pro64_ar (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w10pro64_ja (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w10pro64_zh_CN (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== w11pro64_amd (64 bit report) ===

ntdll:
info.c:369: Test failed: Expected STATUS_NOT_IMPLEMENTED on non-UEFI boots.
info.c:377: Test failed: Expected STATUS_SUCCESS or STATUS_VARIABLE_NOT_FOUND.
info.c:380: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:383: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:386: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:389: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:392: Test failed: Expected STATUS_INVALID_PARAMETER.
info.c:395: Test failed: Expected STATUS_SUCCESS.
info.c:398: Test failed: Expected STATUS_SUCCESS.
info.c:401: Test failed: Expected STATUS_SUCCESS.

=== debian11b (64 bit WoW report) ===

kernel32:
comm.c:1586: Test failed: Unexpected time 1002, expected around 500