Re: [PATCH 0/10] MR607: Draft: vkd3d-shader/ir: Introduce a simple CFG structurizer.

[Conor McCarthy (＠cmccarthy)]

Conor McCarthy (@cmccarthy) commented about libs/vkd3d-shader/ir.c:
> -
>    if (reg->idx[i].rel_addr)
> -
>        materialize_ssa_to_temps_process_src_param(parser, reg->idx[i].rel_addr);
>
> +}
> -
>
> +static void materialize_ssa_to_temps_process_dst_param(struct vkd3d_shader_parser *parser, struct vkd3d_shader_dst_param *dst)
> +{
> - materialize_ssa_to_temps_process_reg(parser, &dst->reg);
>
> +}
> -
>
> +static void materialize_ssa_to_temps_process_src_param(struct vkd3d_shader_parser *parser, struct vkd3d_shader_src_param *src)
> +{
> - materialize_ssa_to_temps_process_reg(parser, &src->reg);
>
> +}
> -
>
> +static bool materialize_ssa_to_temps_synthesize_mov(struct vkd3d_shader_parser *parser,
> -
>    struct vkd3d_shader_instruction **instructions, size_t *ins_count, const struct vkd3d_shader_location *loc,

Looks like `*instructions` is constant in this function, so must it be passed as a `**`?