On Wed Apr 24 21:59:40 2024 +0000, Aida Jonikienė wrote:
I tested this MR with Need for Speed: World and the game experiences the same vertex explosions as my quick `memcpy()` hack (the game doesn't use a byte offset or objects when calling this function (which are the only things causing test failures on Wine) so I'm not sure if this function is even the issue)
It's certainly possible that there are further issues with NFS:W after SetRawValue() is implemented correctly, but I'm not confident that this MR is actually good enough. We probably need more tests in general and, AFAICS, the unresolved threads still need to be addressed.
In particular, I'm curious if NFS:W tries to set multiple parameters with a single SetRawValue() call. That generally wouldn't work with this and it would be interesting to know if that's something that games actually attempt to do.