Re: [PATCH v2 0/2] MR8382: msvcr120/tests: Add tests for expf.

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcr120/tests/msvcr120.c:
> -
> - __setusermatherr(matherr_callback);
> -
> - for(i=0; i<ARRAY_SIZE(tests); i++) {
> -
>    errno = -1;
> -
>    exception.type = -1;
> -
>    r = expf(tests[i].x);
> -
>    e = errno;
> -
> -
>    if(isnan(tests[i].exp))
> -
>        ok(isnan(r), "expected NAN, got %0.7e for %d\n", r, i);
> -
>    else if(isinf(tests[i].exp))
> -
>        ok(isinf(tests[i].exp) || r == 0.0f, /* 64-bit vs 32-bit windows */
> -
>           "failed for %d\n", i);
> -
>    else{
> -
>        ok(compare_float(r, tests[i].exp, 7),

Is there any reason for keeping error margin that big? All the tests are passing on my machine if 7 is changed to 0.