On Sat Mar 25 16:51:48 2023 +0000, **** wrote:
Marvin replied on the mailing list:
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=131056 Your paranoid android. === w10pro64 (32 bit report) === ddraw: ddraw2.c:9075: Test failed: Failed to set foreground window. ddraw2.c:9077: Test failed: Got unexpected hr 0. ddraw2.c:9079: Test failed: Got unexpected hr 0. ddraw2.c:9081: Test failed: Got unexpected hr 0. ddraw2.c:9083: Test failed: Got unexpected hr 0. ddraw2.c:9093: Test failed: Got unexpected hr 0. ddraw2.c:9095: Test failed: Got unexpected hr 0. ddraw2.c:9097: Test failed: Got unexpected hr 0. ddraw2.c:9101: Test failed: Failed to set foreground window. ddraw2.c:9103: Test failed: Got unexpected hr 0. ddraw2.c:9105: Test failed: Got unexpected hr 0. ddraw2.c:9111: Test failed: Got unexpected hr 0. ddraw2.c:9131: Test failed: Got unexpected hr 0. ddraw2.c:9133: Test failed: Got unexpected hr 0x887600e1. ddraw2.c:9139: Test failed: Got unexpected hr 0. ddraw2.c:9158: Test failed: Failed to set foreground window. ddraw2.c:9170: Test failed: Failed to set foreground window. ddraw2.c:14703: Test failed: WM_KILLFOCUS was not received. ddraw2.c:14739: Test failed: Got unexpected hr 0x887600e1. ddraw2.c:14742: Test failed: Got unexpected hr 0x887600ff. 1c70:ddraw2: unhandled exception c0000005 at 0046236E === w10pro64 (32 bit report) === ddraw: ddraw7.c:17190: Test failed: WM_KILLFOCUS was not received. ddraw7.c:17352: Test failed: Got unexpected hr 0x887600e1. ddraw7.c:17355: Test failed: Got unexpected hr 0x887600ff. 05d4:ddraw7: unhandled exception c0000005 at 0050979A === w10pro64 (64 bit report) === ddraw: ddraw7.c:17190: Test failed: WM_KILLFOCUS was not received. ddraw7.c:17352: Test failed: Got unexpected hr 0x887600e1. ddraw7.c:17355: Test failed: Got unexpected hr 0x887600ff. 1eec:ddraw7: unhandled exception c0000005 at 00000000004E46D0
I am a bit lost regarding those test failures. On the one hand I can't find evidence of the same failures on test.winehq.org. On the other hand, submitting an empty patch to the testbot brings the same ones: https://testbot.winehq.org/JobDetails.pl?Key=131083#k234
They are flaky though: I resubmitted the test diff and the testbot did not find any issues: https://testbot.winehq.org/JobDetails.pl?Key=131082