17 Mar
2025
17 Mar
'25
12:07 p.m.
On Sun Mar 16 20:50:11 2025 +0000, Gabriel Ivăncescu wrote:
changed this line in [version 10 of the diff](/wine/wine/-/merge_requests/6855/diffs?diff_id=164468&start_sha=888fb5d04755db9b96c04dcfae087012480a9562#21721cceaf2ea82f93539de2c6e01cc016bbac65_2597_2603)
I notice you dropped the fstatat(). It was there to reduce chance for race and/or conflict with accidental leftover tmpnames.
If you don't like the fstatat(), we can use `mkdirat( dirfd, tmpname, 0777 )` to atomically probe for existence and create an empty directory that will be replaced by `renameat()`.
(Yes, rename(2) replaces empty directories.)