On Fri Aug 26 17:30:24 2022 +0000, R��mi Bernon wrote:
You don't need to AddRef / Release here. Also I'm just reading this quickly but if it's actually implemented you could probably change the trace to TRACE and not FIXME / stub. One good habit is also to first implement a class or an interface as complete stub first, then implement each method individually (or a few at a time), adding the required members and code to the class and removing the FIXME. Eventually interleaving with new tests for the methods in a first commits with todo_wine, and then the commit implementing the methods with the todo_wine removed.
I did the AddRef/Release there because otherwise the bug I am fixing does not actually fix. It will free itself while invoking event handlers and it just causes a lot of issues, and this is also what I think the internal behavior on Windows is from tests I had written earlier.
Do I need to make more commits for the stubs or can I just leave it for this time?