Re: [PATCH v6 0/3] MR564: cabinet: implement DllGetVersion & GetDllVersion

[Bernhard Kölbl (＠besentv)]

On Mon Aug  1 18:01:50 2022 +0000, Tobias G��rgens wrote:
> So, I renamed this pr and my commits to follow the (hopefully now)
> correct name scheme and split the commit into smaller ones, one adding
> the test itself and expecting it to fail, one with the implementation of
> DllGetVersion and related changes + not failing test and one with
> DllGetVersion + not failing test anymore.
> Is this the recommended way?
> Can I improve my pr/commits in any other way?
> Thank you very much! :)

Tests cannot fail in their own commit. You need to denote stuff, that's going to be implemented with todo_wine, which expects a failure. Then the commit message for tests needs to be cabinet/tests: