On Fri Sep 15 07:14:43 2023 +0000, Ziqing Hui wrote:
OK, so the conclusion is that for this patch, we cannot simply change "byte-stream" to "avc" in wg_format_to_caps_video_h264(). We'd better add a h264parse while we are adding a h264 stream to mp4muxer, correct?
I'm not sure that's the best solution, although perhaps the easiest. The h264parse plugin is sometimes not available. We don't have it in Proton for instance.
I think the right solution would be to decide whether we should use "byte-stream" or "avc" depending on the media type. Maybe convert from "byte-stream" to "avc" ourselves, although I'm not entirely confident that this is fine wrt. patents, or rely on having another muxer selected instead.
Btw, I think the muxer selection is not optimal for this situation, as it will not take into account the stream caps, but only the container. Maybe it should be done differently so that another muxer, which would support "byte-stream" format, could be used.