On Mon Nov 14 04:32:44 2022 +0000, Jinoh Kang wrote:
So this basically brings us back to v9 of !155: https://gitlab.winehq.org/wine/wine/-/merge_requests/155/diffs?commit_id=354.... Note that this v9 patch was submitted *before* I eventually asked if we "need comments on read-acq side as well" on IRC; then, I interpreted your response "yes, both sides should have comments" in a way that requires both sides to have detailed comments. Perhaps I should have mentioned that I have made several modifications before asking there, so that you didn't have to work with outdated information. Either way, thanks for your clarification!
I probably never looked at that specific revision, and assumed from your private question that it still had no comments at all.
I did make a couple other modifications while I was at it.