Re: [PATCH 0/6] MR7711: d3dx9: Rework color key handling.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/surface.c:
> -
> -
>    const void *expected_dst_data;
> -
>    D3DCOLOR color_key;
> -
>    BOOL todo;
> - } tests[] =
> - {
> -
>    /* Color key with alpha channel unset. */
> -
>    {
> -
>        D3DFMT_R8G8B8, NULL, { 0, 0, 4, 4 }, r8g8b8_4_4, r8g8b8_4_4_expected, 0x00008080,
> -
>        .todo = TRUE
> -
>    },
> -
>    /* Same color key as before except the alpha channel is set. */
> -
>    {
> -
>        D3DFMT_R8G8B8, NULL, { 0, 0, 4, 4 }, r8g8b8_4_4, r8g8b8_4_4_expected, 0xff008080,
> -
>        .todo = TRUE
> -
>    },

I'd be curious to see a test with some pixels matching the color key in the RGB part but not alpha, to make sure that alpha isn't just ignored.