Rémi Bernon (@rbernon) commented about dlls/cfgmgr32/main.c:
params_len, params, objs_len, objs );
- if (!!props_len != !!props || !!filters_len != !!filters || !!params_len != !!params || (flags & ~valid_flags))
return E_INVALIDARG;
- if (props || flags & DevQueryFlagAllProperties)
FIXME( "Object properties are not supported!\n" );
- if (filters)
FIXME( "Query filters are not supported!\n" );
- if (params)
FIXME( "Query parameters are not supported!\n" );
- *objs = NULL;
- *objs_len = 0;
- hr = enum_dev_objects( type, dev_objects_append, &objects ); if (hr == S_OK)
What about using SUCCEEDED(hr) instead, I think it's what we do in general in implementation, rather than checking for S_OK (to the contrary to tests where actual value sometimes matters).