On Mon Mar 10 12:44:26 2025 +0000, Brendan McGrath wrote:
MR !7493 has been merged, so I'm marking this one as ready. Whilst false positives are theoretically possible, it should be unlikely. Short of implementing more sophisticated probing, I think this is the best I can do. I've ensured the MP3 checks come last, so it won't be possible for false positives to occurs with the prior formats. And although ID3 tags can appear in other formats, in practice it seems they are almost exclusively used in the MP3 format.
More sophisticated probing will have to read IDv2 format, looking for data section tags I guess. It's not impossible to do, but I agree that we'll need a use case first. I don't think there is a separate concept of containers formats and media formats that they can contain, so I can imagine it could be using some stripped down version of IDv2 parser to resolve types and then the full thing (if there is metadata support at all for mp3), in specific sources.