Re: [PATCH v5 0/1] MR8367: shell32: Try to lookup icon, with fallback on failure

[James McDonnell (＠ElementalWarrior)]

On Sun Jul 20 03:30:00 2025 +0000, Zhiyi Zhang wrote:
> Please add some tests. And I don't think falling back to IDI_SHELL_HELP
> is correct.

Well no, its not. But it at least returns an icon. There are only 43 icons defined in dlls/shell32/resources. But this function is supposed to return something like 180.

This at least returns an icon, as opposed to failing because the icon does not exist.