Re: [PATCH v17 0/8] MR4982: Load and play MIDI

[Yuxuan Shui (＠yshui)]

On Tue Feb  6 16:34:45 2024 +0000, Rémi Bernon wrote:
> Do we really need this check (and the additional read_accumulate helper
> it requires)?
> I understand how it might seem important for correctness, but checks
> need to be preferably either trivial (like parameter checks), or
> something that Windows does and that applications would need.
> Ideally, any check should have a corresponding test to make sure it can
> be added without making the behavior different (let's imagine
> applications with bogus MIDI files and Windows maybe just parses
> whatever it can from them).

I can change this to use `IStream_Seek` to find out the current position, instead of tracking it across reads. is that reasonable?