17 Sep
2024
17 Sep
'24
8:07 p.m.
On Tue Sep 17 18:42:13 2024 +0000, Rémi Bernon wrote:
Well, even in the first case I'm not sure to understand what it is supposed to do. There's already a check at the top of the function to make sure we can read the struct from the data. Then there's separate checks to make sure we have enough data for the icon bitmaps, I don't think these are useful.
actually this check isn't even needed at all in both cases, because the real overflow check is performed below anyway