Re: [PATCH v4 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/effect.c:
> -
>        ok( hr == test_set_raw_data_values[x].expected_result,
> -
>                "Test # %#1.1x var name %s : got HRESULT %#1.1x, expected %#1.1x.\n", x,
> -
>                test_set_raw_data_values[x].param_name, hr,
> -
>                test_set_raw_data_values[x].expected_result );
> -
>        effect->lpVtbl->GetValue( effect,
> -
>                effect->lpVtbl->GetParameterByName( effect, NULL, test_set_raw_data_values[x].param_name ),
> -
>                result_buf,
> -
>                test_set_raw_data_values[x].expected_data_len );
> -
>        switch (test_set_raw_data_values[x].param_type)
> -
>        {
> -
>            case D3DXPT_BOOL:
> -
>            case D3DXPT_INT:
> -
>            case D3DXPT_FLOAT:
> -
>                single_size = (test_set_raw_data_values[x].param_type == D3DXPT_BOOL) ? sizeof( BOOL ) :
> -
>                        (test_set_raw_data_values[x].param_type == D3DXPT_INT) ? sizeof( DWORD ) :
> -
>                        sizeof( FLOAT );

element_size? scalar_size?

Practically speaking, those are all 4 bytes. I don't see any issue in hardcoding a sizeof(DWORD) where needed here in the tests.