Re: [PATCH v2 0/7] MR4982: Draft: Load and play MIDI

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmime/miditracks.c:
> - return S_OK;
>
> +}
> -
>
> +static const IPersistStreamVtbl midi_sequence_track_persiststream_vtbl =
> +{
> - dmobj_IPersistStream_QueryInterface,
> - dmobj_IPersistStream_AddRef,
> - dmobj_IPersistStream_Release,
> - dmobj_IPersistStream_GetClassID,
> - unimpl_IPersistStream_IsDirty,
> - track_IPersistStream_Load,
> - unimpl_IPersistStream_Save,
> - unimpl_IPersistStream_GetSizeMax
>
> +};
> -
>
> +HRESULT create_midiseqtrack(REFIID riid, void **ppobj)

In this first change, that function is never called, so all the code you add is essentially dead code.

You should reorder and split the commits to make sure the code is reachable (ideally reached, and tested).

It's usually done by having the tests first in the commit order, then implementing a completed stubbed class, and then implementing the class methods one by one.