On Thu Feb 29 17:23:38 2024 +0000, Sven Baars wrote:
I am not very knowledgeable in this area, so I don't think I can give any useful comments on the code, but I have some questions:
- Why call `maybeHideDockIconDueToWindowOrderingOut` in those two places
specifically? And why isn't `doOrderOut` called when the window is closed?
- Is this supposed to work with CrossOver as is? The situation with
Steam seems even weirder than before. For instance the first dock icon is the default icon, which stays until you close all Steam windows (news, friends list, main window) and then open another, after which it will have the Steam icon instead of the default icon.
`doOrderOut` is called when a window is closed, but the reverse isn't always true - there are times when a window orders out, but not in response to it being closed (just being hidden, for example). So that check needs to happen in two places to catch both cases.
As for the CrossOver situation, we can discuss that internally. There's another piece that needs to come in because of the proxy apps we make. I am concerned about the default app icon showing up in the dock though. Let me see if I can reproduce that.