Re: [PATCH 0/3] MR5845: opcservices: Provide memory allocator functions to zlib

[Nikolay Sivov (＠nsivov)]

On Thu Jun 13 18:33:48 2024 +0000, Danyil Blyschak wrote:
> If these functions aren't provided, the later call to zlib's deflate()
> returns an error, and so it's unable to compress the input data and
> process it later. I discovered this working on a bug where Word was
> unable to open a doc from a pdf file; in that context, the deflate()
> failure  meant that wine wasn't able to compress document data and
> eventually write it to a .docx file, which led to a corrupted .docx file.

That's exactly the use case this library was added for initially, and it was able to create archives I think. But I can see now that default allocation functions are disabled with Z_SOLO, and old code we used before that didn't even have defaults.