On 11/3/22 12:10, Paul Gofman wrote:
On 11/3/22 12:01, Bernhard Kölbl (@besentv) wrote:
Bernhard Kölbl (@besentv) commented about dlls/windows.gaming.ui.gamebar/main.c:
return S_OK; } + if (IsEqualGUID( iid, &IID_IGameBarStatics )) + { + *out = &impl->IGameBarStatics_iface; + IInspectable_AddRef( *out );
You could probably make this a one-liner as well, like in line 52.
TBH I intentionally removed it (and missed in line 52) as in general I think assignment in a function call argument used to be considered a bad practice in Wine. Unless anyone feels striong about it I'd rather change it in line 52.
Actually, IInspectable_AddRef is a macro, which gives more reasons to avoid assignment in the argument as a general practice.