On Fri Sep 8 08:14:03 2023 +0000, Rémi Bernon wrote:
I don't understand how the enum is useful for anything, it requires additional changes to convert it to GStreamer caps, and that's true for every new format we could add. Having a `char *` provided by the client, you could simply call `gst_caps_from_string` on it from the unix side and it will let us support any format without having to add it to the conversion function. Yes, you need to convert that pointer in the wow64 thunk, but you do that already for the format pointer, so it's not worse (and in any case I don't think it's a big deal).
OK, I found that I misunderstood something... You quoted only `enum wg_quicktime_variant` here so I thought you are talking about only replace `wg_quicktime_variant` with string and remain the `struct wg_container_format`.
But what you mean is that we get rid of the whole `struct wg_container_format`, replace it with a string, right? If that's true, it works good for me.