On Tue Nov 19 01:42:52 2024 +0000, Hans Leidekker wrote:
When a db is transacted, we need to call `Commit` to actually save the
changes, but tests show this is not how
msi works, so I changed `MsiGetSummaryInformationW` to open the db
directly instead. Your test shows that this is not how it works for a database that is opened by MsiGetSummaryInformationW(). The case where a transacted database handle is passed may work correctly but your tests don't cover that. Maybe you could add a test for that and update the commit message to reflect this nuance?
Not sure what you mean, my first test checked what happens if you try to persist on a transacted handle. I added another test for persisting on a directly opened database for completeness.
What exactly should I change here?