Re: [PATCH 0/1] MR2609: shlwapi: Implement StrFormatByteSizeEx

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/shlwapi/string.c:
> -
> - RETURNS
> -
> - S_OK if conversion is successful otherwise returns a HRESULT error code.
> -
> -
> - */
> -
>
> +HRESULT WINAPI StrFormatByteSizeEx(LONGLONG llBytes, SFBS_FLAGS flags, LPWSTR lpszDest,
> -
>                               UINT cchMax)
>
> +{
> - WCHAR wszAdd[] = {' ','?','B',0};
> - double dBytes;
> - SHLWAPI_BYTEFORMATS bfFormat;
> -
> - TRACE("(0x%s,%d,%p,%d)\n", wine_dbgstr_longlong(llBytes), flags, lpszDest, cchMax);
> -
> - if (!cchMax || (flags < 1 || flags > 2))
> - return E_INVALIDARG;

Flag checks like that are not very readable. Does flags == 0 work?