Re: [PATCH v3 0/3] MR5195: ws2_32: Implement TCP_KEEPALIVE, TCP_KEEPCNT and TCP_KEEPINTVL socket options

[Florian Will (＠w-flo)]

On Fri Mar  1 09:00:51 2024 +0000, Zebediah Figura wrote:
> We've had problems in the past with applications being very picky about
> how we do parameter validation, so I'd like to be proactive about
> getting that right, or at least not copy it from elsewhere without
> testing. The relevant tests are a bit tricky to read, so I've taken the
> liberty of adding them and adjusting the implementation appropriately;
> would you mind fixing up your patches accordingly?
> [scratch.diff](/uploads/ecf33271bf2f18bce38f7ef6daf40aa7/scratch.diff)

Thanks a lot, that's pretty useful! I had to add a new member to the test definition struct for old windows (and initially the wine todo), I hope that's okay. If you'd prefer a different approach, just let me know.