Re: [PATCH v5 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c:
> -
>    /* First up then down */
> -
>    { TRUE,  FALSE, VK_UP,   2, "select multiple via SHIFT+UP",
> -
>      ownerdata_multiselect_select_3_to_2_odstatechanged_seq, FALSE },
> -
>    { TRUE,  FALSE, VK_DOWN, 1, "select one item via SHIFT+DOWN",
> -
>      ownerdata_multiselect_select_3_modkey_odstatechanged_seq, TRUE },
> -
>    { TRUE,  TRUE,  VK_UP,   2, "select multiple via SHIFT+CONTROL+UP",
> -
>      ownerdata_multiselect_select_3_to_2_odstatechanged_seq, FALSE },
> -
>    { TRUE,  TRUE,  VK_DOWN, 1, "select one item via SHIFT+CONTROL+DOWN",
> -
>      ownerdata_multiselect_select_3_modkey_odstatechanged_seq, TRUE },
> -
>    { FALSE, TRUE,  VK_UP,   1, "keep selection but move cursor via CONTROL+UP",
> -
>      ownerdata_multiselect_move_3_to_2_odstatechanged_seq, FALSE },
> -
>    { TRUE,  TRUE,  VK_UP,   3, "select multiple after skip via SHIFT+CONTROL+UP",
> -
>      ownerdata_multiselect_select_3_to_1_odstatechanged_seq, FALSE },
> -
>    { FALSE, FALSE, VK_UP,   1, "deselect all, select item 0 via UP",
> -
>      ownerdata_multiselect_select_0_odstatechanged_seq, FALSE },
> - };

Hi, we usually mark such test sequences static const. Also the struct is usually not exposed to other tests. I made a patch at https://pastebin.com/XycMrvjq. Otherwise, things look good. Thanks.