3 May
2023
3 May
'23
3:09 p.m.
By making it simpler do you mean removing tests?
- In that case, which subset of the conclusions above would you like to remove?
- Otherwise, are you saying that the declarative approach (`manifest_res_spec` arrays) is unreadable compared to imperative / procedural one?
I don't know, my comment is mostly based on the time it took me to read the new tests, trying to understand what they were doing, and the apparent simplicity of the fix, which basically just takes the first RT_MANIFEST resource.
I think that all the detail about resource ordering seems to be a LdrFindResourceDirectory_U behavior, rather than something related to activation contexts.
Well, so far I assumed that leftover `todo_wine`s are harmless. Is there any reason you'd like them removed?
No, but given the number of tests I thought at first that it was a new corner case that was left unfixed. But it's actually unrelated, and imho also a sign that the tests could be made simpler.