[PATCH v4 10/10] comdlg32: Avoid taking focus on LMB click in IFileDialog navigation bar buttons.

[Vladislav Timonin]

From: Vladislav Timonin

With exception of overflow button,
since it's a split button, it breaks the dropdown.
---
 dlls/comdlg32/navbar.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/dlls/comdlg32/navbar.c b/dlls/comdlg32/navbar.c
index 14907ed09ab..4f9ceeab4f9 100644
--- a/dlls/comdlg32/navbar.c
+++ b/dlls/comdlg32/navbar.c
@@ -40,6 +40,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(commdlg);
 #define IDC_OVERFLOW 205

#define FRAME_SUBCLASS_ID 1
+#define BUTTON_SUBCLASS_ID 2

typedef struct {
     HWND parent_hwnd;
@@ -184,6 +185,22 @@ static LRESULT NAVBAR_OVERFLOW_DrawIcon(HWND hwnd, NAVBAR_INFO *info, UINT msg,
     return DefWindowProcW(hwnd, msg, wparam, lparam);
 }

+static LRESULT CALLBACK NAVBAR_ButtonProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam, UINT_PTR id_subclass, DWORD_PTR ref_data)
+{
+    switch (msg)
+    {
+        case WM_LBUTTONDOWN:
+        case WM_LBUTTONDBLCLK:
+        {
+            /* avoid taking focus by sending a keypress instead */
+            SendMessageW(hwnd, WM_KEYDOWN, VK_SPACE, 0);
+            return 0; /* processed */
+        }
+    }
+
+    return DefSubclassProc(hwnd, msg, wparam, lparam);
+}
+
 static LRESULT CALLBACK NAVBAR_FRAME_SubclassProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam, UINT_PTR id_subclass, DWORD_PTR ref_data)
 {
     switch (msg)
@@ -403,6 +420,7 @@ static LRESULT NAVBAR_Create(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam)
     SendMessageW(info->back_btn_hwnd, WM_SETFONT, (WPARAM)gui_font, FALSE);
     set_icon(info->icons, ILI_BACK, info->back_btn_hwnd);
     set_title_and_add_tooltip(info, info->back_btn_hwnd, IDS_BACK);
+    SetWindowSubclass(info->back_btn_hwnd, NAVBAR_ButtonProc, BUTTON_SUBCLASS_ID, (DWORD_PTR)info);

x += cs->cy + gap;
     info->fwd_btn_hwnd = CreateWindowExW(0, WC_BUTTONW, NULL,
@@ -412,6 +430,7 @@ static LRESULT NAVBAR_Create(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam)
     SendMessageW(info->fwd_btn_hwnd, WM_SETFONT, (WPARAM)gui_font, FALSE);
     set_icon(info->icons, ILI_FORWARD, info->fwd_btn_hwnd);
     set_title_and_add_tooltip(info, info->fwd_btn_hwnd, IDS_FORWARD);
+    SetWindowSubclass(info->fwd_btn_hwnd, NAVBAR_ButtonProc, BUTTON_SUBCLASS_ID, (DWORD_PTR)info);

x += cs->cy + gap;
     info->up_btn_hwnd = CreateWindowExW(0, WC_BUTTONW, NULL,
@@ -421,6 +440,7 @@ static LRESULT NAVBAR_Create(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam)
     SendMessageW(info->up_btn_hwnd, WM_SETFONT, (WPARAM)gui_font, FALSE);
     set_icon(info->icons, ILI_UP, info->up_btn_hwnd);
     set_title_and_add_tooltip(info, info->up_btn_hwnd, IDS_UPFOLDER);
+    SetWindowSubclass(info->up_btn_hwnd, NAVBAR_ButtonProc, BUTTON_SUBCLASS_ID, (DWORD_PTR)info);

x += cs->cy + gap;
     info->frame_hwnd = CreateWindowExW(0, WC_STATICW, NULL,
@@ -575,6 +595,7 @@ static LRESULT NAVBAR_SetPIDL(HWND hwnd, NAVBAR_INFO *info, UINT msg, WPARAM wpa
         SendMessageW(crumb1->hwnd, WM_SETFONT, (LPARAM)gui_font, FALSE);
         SendMessageW(crumb1->hwnd, BCM_GETIDEALSIZE, 0, (LPARAM)&full_size);
         SetWindowLongPtrW(crumb1->hwnd, GWLP_USERDATA, (LPARAM)crumb1->pidl);
+        SetWindowSubclass(crumb1->hwnd, NAVBAR_ButtonProc, BUTTON_SUBCLASS_ID, (DWORD_PTR)info);

crumb1->full_w = full_size.cx + padding;
         crumb1->current_w = crumb1->full_w;