Re: [PATCH 0/5] MR5971: winegstreamer/video_encoder: More of encoder implementation.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/video_encoder.c:
>  return hr;
>
> }
>
> +static HRESULT update_output_info(struct video_encoder *encoder)
> +{
> - UINT64 frame_size;
> - HRESULT hr;
> -
> - if (FAILED(hr = IMFMediaType_GetUINT64(encoder->output_type, &MF_MT_FRAME_SIZE, &frame_size)))
> -
>    return hr;
> -
> - /* FIXME: It's hard to calculate the encoded output size,
> -
> * use a uncompressed size here and hope it will work. */
> - return MFCalculateImageSize(&MFVideoFormat_NV12, frame_size >> 32, frame_size,
> -
>        (UINT32 *)&encoder->output_info.cbSize);

This doesn't look right and we could return a hardcoded value just as well for now.

I'm not sure where this information comes from but if it really matters maybe we need a way to get it from the actual encoder?

The same question goes for `MF_MT_MPEG_SEQUENCE_HEADER`, is it possible to get it from GStreamer? Or does it simply not matter?