Re: [PATCH 0/5] MR2587: Support MF DXGI device manager in h264 decoder

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/h264_decoder.c:
> -
>    IUnknown *unk = (IUnknown *)param;
> -
> -
>    FIXME("MFT_MESSAGE_SET_D3D_MANAGER.\n");
> -
> -
>    if (unk && FAILED(hr = IUnknown_QueryInterface(unk, &IID_IMFDXGIDeviceManager, (void **)&dxgi_manager)))
> -
>    {
> -
>        FIXME("Query IMFDXGIDeviceManager failed.\n");
> -
>        return hr;
> -
>    }
> -
>    if (decoder->dxgi_manager)
> -
>        IMFDXGIDeviceManager_Release(decoder->dxgi_manager);
> -
>    decoder->dxgi_manager = dxgi_manager;
> - }
> -
> - FIXME("Ignoring message %#x.\n", message);
> return S_OK;

I'm not sure the FIXME messages really make sense in the way they are written here. The first one is later removed for instance, and the latter will always be reached although it's not really ignored even here.