Re: [PATCH v3 0/1] MR2045: d3d12core: Add stub DLL.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/d3d12core/version.rc:
> -
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -
> - Lesser General Public License for more details.
> -
> -
> -
> - You should have received a copy of the GNU Lesser General Public
> -
> - License along with this library; if not, write to the Free Software
> -
> - Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
> - */
> -
>
> +#define WINE_FILEDESCRIPTION_STR "Wine Direct3D 12 Core Runtime"
> +#define WINE_FILENAME_STR "d3d12core.dll"
> +#define WINE_FILEVERSION 10,0,18363,1350
> +#define WINE_FILEVERSION_STR "10.0.18363.1350"
> +#define WINE_PRODUCTVERSION 10,0,18363,1350
> +#define WINE_PRODUCTVERSION_STR "10.0.18363.1350"
> -
>
> +#include "wine/wine_common_ver.rc"

Do you need this?