Re: [PATCH v63 0/6] MR2786: Add support for AF_UNIX sockets

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about server/sock.c:
>              break;
>      }
>
> -
>    unix_len = sockaddr_to_unix( addr, params->addr_len, &unix_addr );
> -
>    if (sock->family == WS_AF_UNIX)
> -
>    {
> -
>        if (*((struct WS_sockaddr_un *)&addr)->sun_path)
> -
>        {
> -
>            int unix_path_len = *(int *)((char *)(params + 1) + params->addr_len);
> -
>            char *unix_path = (char *)(params + 1) + params->addr_len + sizeof(unix_path_len);
> -
>            char *base_name;
> -
>            unix_path[unix_path_len - 1] = '\0';
> -

You should not be sending the final null, or the length, this can be determined from the size of the total data. Also modifying the input buffer is not nice.

And could you please avoid updating your MR every day even if nothing changed? It makes it hard to notice actual changes, and wastes CI resources. Thanks.