Francisco Casas (@fcasas) commented about libs/vkd3d-shader/tpf.c:
static void sm4_src_from_deref(struct hlsl_ctx *ctx, struct sm4_src_register *src, const struct hlsl_deref *deref, unsigned int map_writemask) {
- unsigned int writemask, hlsl_swizzle;
- uint32_t writemask;
- unsigned int hlsl_swizzle;
Our convention is that declaration lines should be from longest to shortest, so `unsigned int hlsl_swizzle;` should be first here.
Same for sm4_src_from_node() and in write_sm4_swizzle().