Re: [PATCH 0/6] MR259: vkd3d-shader/dxil: Read the DXIL module.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> - {
> -
>    record = block->records[i];
> -
> -
>    if (record->code != VST_CODE_ENTRY)
> -
>    {
> -
>        FIXME("Unhandled symtab code %u.\n", record->code);
> -
>        continue;
> -
>    }
> -
>    if (record->operand_count < 2)
> -
>    {
> -
>        WARN("Missing operands for function symbol %u.\n", sm6->global_symbol_count);
> -
>        continue;
> -
>    }
> -
> -
>    symbol = &sm6->global_symbols[sm6->global_symbol_count];
> -
>    symbol->id = record->operands[0];

Are IDs supposed to be unique? Should we validate that?

BTW, what's the typical number of symbols you're seeing here? Given that in later patches you're linearly scanning throught this array, would it make sense to sort it from the get-go and then use a binary search?